tillrohrmann commented on a change in pull request #10362:
[FLINK-14792][coordination] Implement TE cluster partition release
URL: https://github.com/apache/flink/pull/10362#discussion_r394495846
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/TestingTaskExecutorPartitionTracker.java
##########
@@ -73,6 +75,10 @@ public void
setStopTrackingPartitionsFunction(Function<Collection<ResultPartitio
this.stopTrackingPartitionsFunction =
stopTrackingPartitionsFunction;
}
+ public void
setReleaseClusterPartitionsConsumer(Consumer<Collection<IntermediateDataSetID>>
releaseClusterPartitionsConsumer) {
+ this.releaseClusterPartitionsConsumer =
releaseClusterPartitionsConsumer;
+ }
Review comment:
This might be a bit out of scope for this PR but I would rather recommend
using a builder for building a `TestingTaskExecutorPartitionTracker` instead of
a mutable setters for changing the behaviour of the testing mock after creating
it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
