GJL edited a comment on issue #11453: [FLINK-13553][tests] Fix ByteBuf leak in KvStateServerHandlerTest URL: https://github.com/apache/flink/pull/11453#issuecomment-601314288 I don't see a benefit in doing this. Since this is a unit test, we should fail the build immediately if a test fails. Moreover, we are already not doing it in Flink https://github.com/apache/flink/blob/067c044cca59f87110f14e021a8fd04d58d0abd6/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/AbstractByteBufTest.java#L137-L140 and it's also not done in the Netty project itself: https://github.com/netty/netty/blob/b5230c7b9c38e4c1e3a611c6ce1e057252b98ed6/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocket08EncoderDecoderTest.java#L101
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
