zhijiangW commented on a change in pull request #11453: [FLINK-13553][tests]
Fix ByteBuf leak in KvStateServerHandlerTest
URL: https://github.com/apache/flink/pull/11453#discussion_r395433462
##########
File path:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/KvStateServerHandlerTest.java
##########
@@ -544,6 +552,7 @@ public void testIncomingBufferIsRecycled() throws
Exception {
channel.writeInbound(unexpected);
assertEquals("Buffer not recycled", 0L, unexpected.refCnt());
+ channel.finishAndReleaseAll();
Review comment:
I am curious of why we add this action only for this test, and actually the
allocated buffers in this unit test are already released before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
