GJL commented on issue #11453: [FLINK-13553][tests] Fix ByteBuf leak in 
KvStateServerHandlerTest
URL: https://github.com/apache/flink/pull/11453#issuecomment-601579753
 
 
   > But I noticed the description of FLINK-13553 for TimeoutException, so i am 
curious that the memory leak would cause the timeout issue?
   
   I don't know if this patch will fix all problems of FLINK-13553. However, 
one of the problems now is that we may not be able to allocate a new buffer to 
serialize the response:
   
https://github.com/apache/flink/blob/0619a5b3e000855f00d11e71ae2f1b9deef05c98/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java#L248
   If that happens the error is swallowed in `AbstractServerHandler`, and the 
test code will wait in vain for the response until a timeout is reached:
   
https://github.com/apache/flink/blob/0619a5b3e000855f00d11e71ae2f1b9deef05c98/flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/KvStateServerHandlerTest.java#L720
   
   I'll create a new ticket and leave FLINK-13553 open for now. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to