azagrebin commented on a change in pull request #11408:
[FLINK-15989][FLINK-16225] Improve direct and metaspace out-of-memory error
handling
URL: https://github.com/apache/flink/pull/11408#discussion_r395584885
##########
File path:
flink-core/src/main/java/org/apache/flink/core/memory/MemorySegmentFactory.java
##########
@@ -94,7 +99,15 @@ public static MemorySegment
allocateUnpooledOffHeapMemory(int size) {
* @return A new memory segment, backed by unpooled off-heap memory.
*/
public static MemorySegment allocateUnpooledOffHeapMemory(int size,
Object owner) {
- ByteBuffer memory = ByteBuffer.allocateDirect(size);
+ ByteBuffer memory;
+ try {
+ memory = ByteBuffer.allocateDirect(size);
+ } catch (OutOfMemoryError e) {
+ if (ExceptionUtils.isDirectOutOfMemoryError(e)) {
+
LOG.error(ExceptionUtils.TM_DIRECT_OOM_ERROR_MESSAGE, e);
+ }
+ throw e;
+ }
Review comment:
I suggest we keep this change to address this reported problem
[FLINK-15981](https://issues.apache.org/jira/browse/FLINK-15981) and log it on
sender side until we establish a general error reporting for the sender. The
error message, got by receiver, is also improved now in a separate commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
