zentol commented on a change in pull request #11195: [FLINK-16222][runtime] Use
plugins mechanism for initializing MetricReporters
URL: https://github.com/apache/flink/pull/11195#discussion_r397676218
##########
File path:
flink-end-to-end-tests/flink-metrics-reporter-prometheus-test/src/test/java/org/apache/flink/metrics/prometheus/tests/PrometheusReporterEndToEndITCase.java
##########
@@ -120,24 +122,51 @@ public static void checkOS() {
public final DownloadCache downloadCache = DownloadCache.get();
@Test
- public void testReporter() throws Exception {
- dist.copyOptJarsToLib("flink-metrics-prometheus");
+ public void reporterWorksWhenFoundInLibsViaReflection() throws
Exception {
+ dist.copyOptJarsToLib(PROMETHEUS_JAR_PREFIX);
Review comment:
I'd opt for creating a separate FlinkResource in every test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
