zentol commented on a change in pull request #11195: [FLINK-16222][runtime] Use 
plugins mechanism for initializing MetricReporters
URL: https://github.com/apache/flink/pull/11195#discussion_r399084928
 
 

 ##########
 File path: 
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/FlinkResourceSetup.java
 ##########
 @@ -69,13 +69,13 @@ public FlinkResourceSetupBuilder 
addConfiguration(Configuration config) {
                        return this;
                }
 
-               public FlinkResourceSetupBuilder moveJar(String jarNamePrefix, 
JarLocation source, JarLocation target) {
-                       this.jarMoveOperations.add(new JarMove(jarNamePrefix, 
source, target));
+               public FlinkResourceSetupBuilder addJarOperation(JarOperation 
jarOperation) {
+                       this.jarOperations.add(jarOperation);
                        return this;
                }
 
                public FlinkResourceSetup build() {
-                       return new FlinkResourceSetup(config, 
Collections.unmodifiableCollection(jarMoveOperations));
+                       return new FlinkResourceSetup(config,  
Collections.unmodifiableCollection(jarOperations));
 
 Review comment:
   ```suggestion
                        return new FlinkResourceSetup(config, 
Collections.unmodifiableCollection(jarOperations));
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to