tillrohrmann commented on a change in pull request #11284: 
[FLINK-15911][runtime] Make Flink work with NAT.
URL: https://github.com/apache/flink/pull/11284#discussion_r396525633
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterConfiguration.java
 ##########
 @@ -106,6 +106,14 @@ public String getTaskManagerBindAddress() {
                                
configuration.getString(TaskManagerOptions.HOST, "localhost");
        }
 
+       public String getJobManagerBindPortRange() {
+               return 
String.valueOf(configuration.getInteger(JobManagerOptions.PORT, 0));
+       }
+
+       public String getTaskManagerBindPortRange() {
+               return configuration.getString(TaskManagerOptions.RPC_PORT);
+       }
 
 Review comment:
   Because of the above-mentioned problems, I think we should remove these 
methods and rely on the random port.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to