tillrohrmann commented on a change in pull request #11284:
[FLINK-15911][runtime] Make Flink work with NAT.
URL: https://github.com/apache/flink/pull/11284#discussion_r396554259
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java
##########
@@ -235,8 +235,8 @@ public static TaskManagerServicesConfiguration
fromConfiguration(
final int externalDataPort =
configuration.getInteger(NettyShuffleEnvironmentOptions.DATA_PORT);
- String bindAddr =
configuration.getString(TaskManagerOptions.BIND_HOST);
- InetAddress bindAddress = bindAddr == null ? externalAddress :
InetAddress.getByName(bindAddr);
+ String bindAddr =
configuration.getString(TaskManagerOptions.BIND_HOST, externalAddress);
+ InetAddress bindAddress = InetAddress.getByName(bindAddr);
Review comment:
Wouldn't this try to resolve `externalAddress` if
`TaskManagerOptions#BIND_HOST` has not been configured. In this case, we should
bind to `0.0.0.0`, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
