tillrohrmann commented on a change in pull request #11284:
[FLINK-15911][runtime] Make Flink work with NAT.
URL: https://github.com/apache/flink/pull/11284#discussion_r396570575
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/KvStateService.java
##########
@@ -170,7 +170,7 @@ public static KvStateService
fromConfiguration(TaskManagerServicesConfiguration
int numProxyServerQueryThreads =
qsConfig.numProxyQueryThreads() == 0 ?
taskManagerServicesConfiguration.getNumberOfSlots() :
qsConfig.numProxyQueryThreads();
kvClientProxy =
QueryableStateUtils.createKvStateClientProxy(
-
taskManagerServicesConfiguration.getTaskManagerAddress(),
+
taskManagerServicesConfiguration.getExternalAddress(),
Review comment:
Not sure, whether this change is valid. The problem is that the underlying
Netty server uses this address to bind against. If the external address is not
resolvable, it might fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
