pnowojski commented on a change in pull request #11491:
[FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
URL: https://github.com/apache/flink/pull/11491#discussion_r396988193
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/OperatorSnapshotFuturesTest.java
##########
@@ -64,22 +66,36 @@ public void testCancelAndCleanup() throws Exception {
SnapshotResult<OperatorStateHandle> operatorStateRawResult =
SnapshotResult.of(operatorRawStateHandle);
RunnableFuture<SnapshotResult<OperatorStateHandle>>
operatorStateRawFuture = spy(DoneFuture.of(operatorStateRawResult));
+ InputChannelStateHandle inputChannelRawStateHandle =
mock(InputChannelStateHandle.class);
+ SnapshotResult<InputChannelStateHandle>
inputChannelStateRawResult = SnapshotResult.of(inputChannelRawStateHandle);
+ RunnableFuture<SnapshotResult<InputChannelStateHandle>>
inputChannelStateRawFuture = spy(DoneFuture.of(inputChannelStateRawResult));
+
+ ResultSubpartitionStateHandle resultSubpartitionRawStateHandle
= mock(ResultSubpartitionStateHandle.class);
+ SnapshotResult<ResultSubpartitionStateHandle>
resultSubpartitionStateRawResult =
SnapshotResult.of(resultSubpartitionRawStateHandle);
+ RunnableFuture<SnapshotResult<ResultSubpartitionStateHandle>>
resultSubpartitionStateRawFuture =
spy(DoneFuture.of(resultSubpartitionStateRawResult));
+
operatorSnapshotResult = new OperatorSnapshotFutures(
keyedStateManagedFuture,
keyedStateRawFuture,
operatorStateManagedFuture,
- operatorStateRawFuture);
+ operatorStateRawFuture,
+ inputChannelStateRawFuture,
+ resultSubpartitionStateRawFuture);
operatorSnapshotResult.cancel();
verify(keyedStateManagedFuture).cancel(true);
verify(keyedStateRawFuture).cancel(true);
verify(operatorStateManagedFuture).cancel(true);
verify(operatorStateRawFuture).cancel(true);
+ verify(inputChannelStateRawFuture).cancel(true);
+ verify(resultSubpartitionStateRawFuture).cancel(true);
Review comment:
ditto about using mockito
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
