pnowojski commented on a change in pull request #11491: 
[FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
URL: https://github.com/apache/flink/pull/11491#discussion_r397979288
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV3Serializer.java
 ##########
 @@ -115,4 +120,31 @@ protected OperatorState 
deserializeOperatorState(DataInputStream dis) throws IOE
 
                return operatorState;
        }
+
+       @VisibleForTesting
+       @Override
+       public void 
serializeResultSubpartitionStateHandle(ResultSubpartitionStateHandle handle, 
DataOutputStream dos) throws IOException {
+               channelStateHandleSerializer.serialize(handle, dos);
+       }
+
+       @VisibleForTesting
+       @Override
+       public ResultSubpartitionStateHandle 
deserializeResultSubpartitionStateHandle(DataInputStream dis) throws 
IOException {
+               final boolean hasResultSubpartitionStateHandle = dis.readInt() 
!= 0;
 
 Review comment:
   Ok. 
   
   Do we have proper test coverage for backward compatibility? Is it going to 
be covered by existing `***MigrationTest`? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to