pnowojski commented on a change in pull request #11491:
[FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
URL: https://github.com/apache/flink/pull/11491#discussion_r397978499
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorFailureTest.java
##########
@@ -116,6 +122,8 @@ public void testFailingCompletedCheckpointStoreAdd()
throws Exception {
verify(operatorSubtaskState.getRawOperatorState().iterator().next()).discardState();
verify(operatorSubtaskState.getManagedKeyedState().iterator().next()).discardState();
verify(operatorSubtaskState.getRawKeyedState().iterator().next()).discardState();
+
verify(operatorSubtaskState.getInputChannelState().iterator().next()).discardState();
+
verify(operatorSubtaskState.getResultSubpartitionState().iterator().next()).discardState();
Review comment:
I'm not asking to rewrite the whole test (although that would be nice ;) ).
Having said that, I would prefer to have mixed test instead of increasing our
dependency on the mockito, as this is adding more and more technological debt.
Also we have lot's of existing tests that are mixing mockito mocked classes
with proper classes, so I don't think this is an issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
