dianfu commented on a change in pull request #11470: [FLINK-16671][python] 
Support for defining scopes and variables on Python metric group
URL: https://github.com/apache/flink/pull/11470#discussion_r397635988
 
 

 ##########
 File path: 
flink-python/src/main/java/org/apache/flink/python/PythonOptions.java
 ##########
 @@ -81,4 +81,13 @@
                        "buffer of a Python worker. The memory will be 
accounted as managed memory if the " +
                        "actual memory allocated to an operator is no less than 
the total memory of a Python " +
                        "worker. Otherwise, this configuration takes no 
effect.");
+
+       /**
+        * The configuration to enable or disable metric for Python UDFs.
+        */
+       public static final ConfigOption<Boolean> PYTHON_UDF_METRIC_ENABLED = 
ConfigOptions
+               .key("python.udf.metric.enabled")
 
 Review comment:
   What about name it as "python.fn-execution.metrics.enabled" or something 
else as this configuration is not only used for Python UDF, but will also used 
for the Python DataStream API which maybe introduced in the future?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to