dianfu commented on a change in pull request #11470: [FLINK-16671][python]
Support for defining scopes and variables on Python metric group
URL: https://github.com/apache/flink/pull/11470#discussion_r397639091
##########
File path:
flink-python/src/main/java/org/apache/flink/table/runtime/runners/python/AbstractPythonStatelessFunctionRunner.java
##########
@@ -250,4 +252,15 @@ public RowType getOutputType() {
*/
@VisibleForTesting
public abstract FlinkFnApi.UserDefinedFunctions
getUserDefinedFunctionsProto();
+
+ /**
+ * Gets the proto representation of the base MetricGroup used for all
user-defined functions.
+ */
+ protected FlinkFnApi.MetricGroupInfo getBaseMetricGroupInfo() {
Review comment:
What about move this method to AbstractPythonFunctionRunner as the metrics
will not only be used by UDF/UDTF, but will also be used by UDAF and the Python
DataStream API which maybe introduced in the future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
