dianfu commented on a change in pull request #11470: [FLINK-16671][python]
Support for defining scopes and variables on Python metric group
URL: https://github.com/apache/flink/pull/11470#discussion_r397630414
##########
File path:
flink-python/src/main/java/org/apache/flink/python/AbstractPythonFunctionRunner.java
##########
@@ -116,17 +119,24 @@
*/
protected transient DataOutputViewStreamWrapper baosWrapper;
+ /**
+ * The flinkMetricContainer will be set to null if metric is configured
to be turned off.
+ */
+ @Nullable protected FlinkMetricContainer flinkMetricContainer;
+
public AbstractPythonFunctionRunner(
String taskName,
FnDataReceiver<byte[]> resultReceiver,
PythonEnvironmentManager environmentManager,
StateRequestHandler stateRequestHandler,
- Map<String, String> jobOptions) {
+ Map<String, String> jobOptions,
+ FlinkMetricContainer flinkMetricContainer) {
Review comment:
Annotate it as @Nullable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
