pnowojski commented on a change in pull request #11541: [FLINK-15416][network]
add task manager netty client retry mechenism
URL: https://github.com/apache/flink/pull/11541#discussion_r400976516
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactoryTest.java
##########
@@ -130,6 +130,23 @@ public void run() {
}
}
+ @Test
+ public void testNettyClientConnectRetry() throws Exception {
+ NettyClient nettyClient = mock(NettyClient.class);
Review comment:
We stopped using mockito for tests (for various of reasons), could you try
to provide a proper mock of `NettyClient` class? Maybe if you used
`NettyTestUtil` you could just implement `NettyClient#connect` method that just
throws an exception on the first invocation, but succeeds (returns real/correct
`ChannelFuture`) on the second attempt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
