pnowojski commented on a change in pull request #11541: [FLINK-15416][network]
add task manager netty client retry mechenism
URL: https://github.com/apache/flink/pull/11541#discussion_r400969493
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java
##########
@@ -234,6 +234,13 @@
.withDeprecatedKeys("taskmanager.net.client.connectTimeoutSec")
.withDescription("The Netty client connection
timeout.");
+ @Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER_NETWORK)
+ public static final ConfigOption<Integer> CLIENT_CONNECT_RETRY =
+ key("taskmanager.network.netty.clientRetry")
+ .defaultValue(0)
+
.withDeprecatedKeys("taskmanager.network.netty.clientRetry")
+ .withDescription("The retry times for building netty
client connection.");
+
Review comment:
I think this option might be more general than just netty and not only for
"client connect retries". Also I think `taskmanager.network.netty` are the
properties that are passed directly to netty config, am I right?
So I would rename it to `taskmanager.network.retries`/`NETWORK_RETRIES`/`The
number of retry attempts for network communication. Currently it's only used
for establishing input/output channel connections.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
