uce edited a comment on issue #11583: [FLINK-16883] Scan FLINK_CONF directory for available log4j configura… URL: https://github.com/apache/flink/pull/11583#issuecomment-607122085 I'm also concerned about this. I'm afraid that it adds another layer of "magic" to the scripts. The original motivation for the ticket was to give higher precedence to user provided Java environment options, e.g. in [flink-console.sh](https://github.com/apache/flink/blob/master/flink-dist/src/main/flink-bin/bin/flink-console.sh#L73) ```bash java ... ${FLINK_ENV_JAVA_OPTS} "${log_setting[@]}" ``` vs. ```bash java ... "${log_setting[@]}" ${FLINK_ENV_JAVA_OPTS} ``` This would allow users to manually overwrite the property when they want to use a custom configuration. As a user I actually expect properties that I specify to have higher precedence.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
