fapaul commented on a change in pull request #11583: [FLINK-16883] Scan
FLINK_CONF directory for available log4j configura…
URL: https://github.com/apache/flink/pull/11583#discussion_r401534614
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -645,3 +645,20 @@ extractExecutionParams() {
echo ${execution_config} | sed "s/$EXECUTION_PREFIX//"
}
+
+findLog4jConfiguration() {
+ local PATH=$1
+ local LOG4J_CONFIG_FILES=($PATH/log4j-console.*)
+ if [[ ${#LOG4J_CONFIG_FILES[@]} -gt 1 ]]; then
+ echo "[ERROR] Found more than one log4j configuration file:
[${LOG4J_CONFIG_FILES[@]}]" 1>&2
+ exit 1
+ fi
+
+ LOG4J_CONFIG=${LOG4J_CONFIG_FILES[0]}
+ if [[ "${LOG4J_CONFIG: -1}" = "*" ]]; then
+ echo "[ERROR] Could not find a valid configuration" 1>&2
+ exit 1
+ fi
Review comment:
Hmm, I am not familiar with the logback setup but I think these changes do
not require more presence of a log4j file than before.
The `findLog4jConfiguration()` call is only used in a subshell which will
`exit 1` and does not affect the main shell. Although I agree the log message
`[ERROR] Could not find a valid configuration` is not ideal because, in the
case of the logback usage, it is probably intended not to have a log4j
configuration.
It might be better to display a warning rather than an error that users are
aware no log4j configuration could be found and it falls back to something else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
