dawidwys commented on a change in pull request #11568: [FLINK-16779][table] Add
RAW type support in DDL and functions
URL: https://github.com/apache/flink/pull/11568#discussion_r401450503
##########
File path:
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/Fixture.java
##########
@@ -28,7 +27,18 @@
* Type used during tests.
*/
public class Fixture {
- private final RelDataTypeFactory typeFactory;
+ private final TestRelDataTypeFactory typeFactory;
+
+ static final String RAW_TYPE_INT_CLASS = "java.lang.Integer";
+ static final String RAW_TYPE_INT_SERIALIZER_STRING =
Review comment:
I checked usages of it and I think it actually does not need to be a
properly serialized Serializer...
How about we replace it with a placeholder? E.g. `<Serialized
TypeSerializer>`. The current string looks a bit intimidating.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
