dawidwys commented on a change in pull request #11568: [FLINK-16779][table] Add
RAW type support in DDL and functions
URL: https://github.com/apache/flink/pull/11568#discussion_r401444600
##########
File path:
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/extraction/DataTypeExtractorTest.java
##########
@@ -74,6 +74,7 @@
@RunWith(Parameterized.class)
public class DataTypeExtractorTest {
+ @SuppressWarnings({"unchecked", "rawtypes"})
@Parameters
Review comment:
How about we add a bit more descriptive message for the tests? It does not
necessarily have to be a manually written description, but I think something
like, could already help to identify the test case:
```
@Parameters(name = "{index}: {0}")
...
TestSpec#toString {
try {
DataType extractedDataType = extractor.apply(typeFactory);
return "extractedDataType=" + extractedDataType + "
expectedDataType=" + expectedDataType;
} catch (Exception ex) {
if (expectedErrorMessage != null) {
return "expectedError: " + expectedErrorMessage;
} else {
return "expectedDataType=" + expectedDataType;
}
}
}
```
At least thats what I wrote to check this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
