dawidwys commented on a change in pull request #11568: [FLINK-16779][table] Add
RAW type support in DDL and functions
URL: https://github.com/apache/flink/pull/11568#discussion_r401514998
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/calcite/FlinkTypeFactory.scala
##########
@@ -484,6 +493,9 @@ object FlinkTypeFactory {
// CURSOR for UDTF case, whose type info will never be used, just a
placeholder
case CURSOR => new TypeInformationRawType[Nothing](new NothingTypeInfo)
+ case null if relDataType.isInstanceOf[RawRelDataType] =>
Review comment:
nit: Wouldn't it be better to assign `SqlTypeName.OTHER` for the
`RawRelDataType`? I am not sure about the consequences, but as far as I could
look around in the codebase `RawRelDataType` would be the only type without
`SqlTypeName`.
Maybe we could ask @danny0405 about his opinion here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
