tillrohrmann commented on a change in pull request #11353: [FLINK-16438][yarn]
Make YarnResourceManager starts workers using WorkerResourceSpec requested by
SlotManager
URL: https://github.com/apache/flink/pull/11353#discussion_r403126015
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -363,31 +356,64 @@ public void onContainersCompleted(final
List<ContainerStatus> statuses) {
@Override
public void onContainersAllocated(List<Container> containers) {
runAsync(() -> {
- log.info("Received {} containers with {} pending
container requests.", containers.size(), numPendingContainerRequests);
- final Collection<AMRMClient.ContainerRequest>
pendingRequests = getPendingRequests();
- final Iterator<AMRMClient.ContainerRequest>
pendingRequestsIterator = pendingRequests.iterator();
+ log.info("Received {} containers.", containers.size());
- // number of allocated containers can be larger than
the number of pending container requests
- final int numAcceptedContainers =
Math.min(containers.size(), numPendingContainerRequests);
- final List<Container> requiredContainers =
containers.subList(0, numAcceptedContainers);
- final List<Container> excessContainers =
containers.subList(numAcceptedContainers, containers.size());
-
- for (int i = 0; i < requiredContainers.size(); i++) {
-
removeContainerRequest(pendingRequestsIterator.next());
- }
-
- excessContainers.forEach(this::returnExcessContainer);
-
requiredContainers.forEach(this::startTaskExecutorInContainer);
+
groupContainerByResource(containers).forEach(this::onContainersOfResourceAllocated);
// if we are waiting for no further containers, we can
go to the
// regular heartbeat interval
- if (numPendingContainerRequests <= 0) {
+ if (pendingWorkerCounter.getTotalNum() <= 0) {
resourceManagerClient.setHeartbeatInterval(yarnHeartbeatIntervalMillis);
}
});
}
- private void startTaskExecutorInContainer(Container container) {
+ private Map<Resource, List<Container>>
groupContainerByResource(List<Container> containers) {
+ return
containers.stream().collect(Collectors.groupingBy(Container::getResource));
+ }
+
+ private void onContainersOfResourceAllocated(Resource resource,
List<Container> containers) {
+ final List<WorkerResourceSpec> pendingWorkerResourceSpecs =
+
workerSpecContainerResourceAdapter.getWorkerSpecs(resource).stream()
Review comment:
Can it happen that `getWorkerSpecs(resource)` returns a list which contains
a `WorkerResourceSpec` twice?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
