tillrohrmann commented on a change in pull request #11353: [FLINK-16438][yarn]
Make YarnResourceManager starts workers using WorkerResourceSpec requested by
SlotManager
URL: https://github.com/apache/flink/pull/11353#discussion_r403130352
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -540,39 +571,41 @@ private FinalApplicationStatus
getYarnStatus(ApplicationStatus status) {
/**
* Request new container if pending containers cannot satisfy pending
slot requests.
*/
- private void requestYarnContainerIfRequired() {
- int requiredTaskManagers = getNumberRequiredTaskManagers();
-
- if (requiredTaskManagers > numPendingContainerRequests) {
- requestYarnContainer();
- }
+ private void requestYarnContainerIfRequired(Resource containerResource)
{
+ getPendingWorkerNums().entrySet().stream()
Review comment:
I have to admit that I find `getPendingWorkerNums()` and
`pendingWorkerCounter` quite confusing. The sound almost the same but the
former means the requirements of the `SlotManager` and the latter the currently
pending workers which have been requested by the RM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
