tillrohrmann commented on a change in pull request #11353: [FLINK-16438][yarn]
Make YarnResourceManager starts workers using WorkerResourceSpec requested by
SlotManager
URL: https://github.com/apache/flink/pull/11353#discussion_r403108543
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java
##########
@@ -584,6 +590,85 @@ public void testGetCpuExceedMaxInt() throws Exception {
}};
}
+ @Test
+ public void testWorkerSpecContainerResourceAdapter_MatchVcores() {
+ final int minMemMB = 100;
+ final int minVcore = 10;
+ final YarnResourceManager.WorkerSpecContainerResourceAdapter
adapter =
+ new
YarnResourceManager.WorkerSpecContainerResourceAdapter(
+ getConfigProcessSpecEqualsWorkerSpec(),
minMemMB, minVcore, true);
Review comment:
It is usually easier to understand if one use an enum instead of boolean
because one can give the different values expressive names (e.g.
`MATCH_VCORES`, `IGNORE_VCORES`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
