xintongsong commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r403799016
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -1206,8 +1206,12 @@ public Void retrievePayload(ResourceID resourceID) {
// Resource Management
//
------------------------------------------------------------------------
- protected int getNumberRequiredTaskManagerSlots() {
- return slotManager.getNumberPendingTaskManagerSlots();
+ protected int getNumberRequiredTaskManagers() {
+ return getPendingWorkerNums().values().stream().reduce(0,
Integer::sum);
Review comment:
IIUC, this is because the RM implementations are ignoring the
`WorkerResourceSpec` passed to `startNewWorker`? Then would it be better to add
this check in `startNewWorker`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
