xintongsong commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r403806981
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ResourceActions.java
##########
@@ -42,9 +40,9 @@
* Requests to allocate a resource with the given {@link
ResourceProfile}.
*
* @param resourceProfile for the to be allocated resource
- * @return Collection of {@link ResourceProfile} describing the
allocated slots
+ * @return whether the resource can be allocated
*/
- Collection<ResourceProfile> allocateResource(ResourceProfile
resourceProfile);
+ boolean allocateResource(ResourceProfile resourceProfile);
Review comment:
I'm not sure whether I have correctly understood your question.
Telling `allocateResource` how big the worker is in the scope of making slot
allocation pluggable. In this PR, we have the SM to tell `allocateResource` the
`WorkerResourceSpec`, in a subsequence commit rather than this one. This PR
does not make the RM implementations to respect the `WorkerResourceSpec` they
are told. We make those changes in subsequence PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
