xintongsong commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r403805525
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -807,23 +811,32 @@ private boolean
isFulfillableByRegisteredSlots(ResourceProfile resourceProfile)
return false;
}
- private Optional<PendingTaskManagerSlot>
allocateResource(ResourceProfile resourceProfile) {
- final Collection<ResourceProfile> requestedSlots =
resourceActions.allocateResource(resourceProfile);
+ private Optional<PendingTaskManagerSlot>
allocateResource(ResourceProfile requestedSlotResourceProfile) {
+ if (defaultWorkerResourceSpec == null) {
+ // standalone mode, cannot allocate resource
+ return Optional.empty();
+ }
- if (requestedSlots.isEmpty()) {
+ if (!Preconditions.checkNotNull(defaultSlotResourceProfile,
+ "defaultSlotResourceProfile should be null iff
taskExecutorProcessSpec is null, which means standalone mode.")
+ .isMatching(requestedSlotResourceProfile)) {
+ // requested resource profile is unfulfillable
return Optional.empty();
- } else {
- final Iterator<ResourceProfile> slotIterator =
requestedSlots.iterator();
- final PendingTaskManagerSlot pendingTaskManagerSlot =
new PendingTaskManagerSlot(slotIterator.next());
-
pendingSlots.put(pendingTaskManagerSlot.getTaskManagerSlotId(),
pendingTaskManagerSlot);
+ }
Review comment:
I'm not sure whether this should be an invalid state exception.
It is true that all the slot requests should have unknown resource profile
ATM. However, I think `SlotManagerImpl` does not necessarily need to know
whether there're custom profiles or not. As long as the requested resource
profile can be matched by the default slot profile, it should be able to
allocate the slot. And if the requested slot profile is larger than the default
slot, an `UnfulfillableSlotRequestException` should be thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
