wsry commented on a change in pull request #11351: [FLINK-16404][runtime] Solve
the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r404584811
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -376,7 +381,7 @@ public int getBuffersInBacklog() {
private boolean shouldNotifyDataAvailable() {
// Notify only when we added first finished buffer.
- return readView != null && !flushRequested &&
getNumberOfFinishedBuffers() == 1;
+ return readView != null && !flushRequested &&
!readView.isBlockedByCheckpoint() && getNumberOfFinishedBuffers() == 1;
Review comment:
Some tags should be checked in lock, I removed the check in
notifyDataAvailable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
