wsry commented on a change in pull request #11351: [FLINK-16404][runtime] Solve
the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r404587258
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/Buffer.java
##########
@@ -227,4 +229,53 @@
* Tags the buffer as compressed or uncompressed.
*/
void setCompressed(boolean isCompressed);
+
+ /**
+ * Gets the type of data this buffer contains.
+ */
+ DataType getDataType();
+
+ /**
+ * Used to identify the type of data contained in {@link Buffer}.
Review comment:
The ordinal of enum value is used when writing buffer to disk and sending
buffers through network. As suggested, I have removed those logic so the
ordinal of enum value is never used now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
