wsry commented on a change in pull request #11351: [FLINK-16404][runtime] Solve
the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r404776325
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -114,7 +114,7 @@ private boolean add(BufferConsumer bufferConsumer, boolean
finish) {
buffers.add(bufferConsumer);
updateStatistics(bufferConsumer);
increaseBuffersInBacklog(bufferConsumer);
- notifyDataAvailable = shouldNotifyDataAvailable() ||
finish;
+ notifyDataAvailable = shouldNotifyDataAvailable();
Review comment:
We don't need special handling for EOF here, if I keep the ```|| finish```,
considering the ```blockByCheckpoint``` tag, the condition looks this
```notifyDataAvailable = shouldNotifyDataAvailable() || (finish &&
!isBlockedByCheckpoint);```, which is not elegant enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
