dianfu commented on a change in pull request #11448:
[FLINK-16666][python][table] Support new Python dependency configuration
options in flink-table.
URL: https://github.com/apache/flink/pull/11448#discussion_r404735802
##########
File path:
flink-python/src/main/java/org/apache/flink/python/env/PythonDependencyInfo.java
##########
@@ -137,18 +129,14 @@ public static PythonDependencyInfo create(PythonConfig
pythonConfig, Distributed
}
Map<String, String> archives = new HashMap<>();
- if (pythonConfig.getPythonArchivesInfo().isPresent()) {
- Map<String, String> archivesMap =
-
mapper.readValue(pythonConfig.getPythonArchivesInfo().get(), HashMap.class);
-
- for (Map.Entry<String, String> entry:
archivesMap.entrySet()) {
- String archiveFilePath =
distributedCache.getFile(entry.getKey()).getAbsolutePath();
- String targetPath = entry.getValue();
- archives.put(archiveFilePath, targetPath);
- }
+ Map<String, String> archivesMap =
pythonConfig.getPythonArchivesInfo();
Review comment:
Remove this local variable as it is difficult to differentiate it with the
local variable `archives`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
