dianfu commented on a change in pull request #11448:
[FLINK-16666][python][table] Support new Python dependency configuration
options in flink-table.
URL: https://github.com/apache/flink/pull/11448#discussion_r404661601
##########
File path:
flink-python/src/main/java/org/apache/flink/client/python/PythonDriver.java
##########
@@ -126,4 +119,18 @@ static GatewayServer startGatewayServer() {
commands.addAll(pythonDriverOptions.getProgramArgs());
return commands;
}
+
+ /**
+ * Constructs the Python configuration which will be used to prepare
the environment of python process.
+ *
+ * @param pythonDriverOptions parsed Python command options
+ */
+ static ReadableConfig constructPythonConfiguration(final
PythonDriverOptions pythonDriverOptions) {
+ Configuration config = new Configuration();
+ config.set(
Review comment:
Could we add some description on why only PYTHON_FILES is used to construct
the configuration?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
