dianfu commented on a change in pull request #11448:
[FLINK-16666][python][table] Support new Python dependency configuration
options in flink-table.
URL: https://github.com/apache/flink/pull/11448#discussion_r404678810
##########
File path:
flink-python/src/main/java/org/apache/flink/client/python/PythonDriverEnvUtils.java
##########
@@ -105,46 +126,113 @@ public void run() {
/**
* Prepares PythonEnvironment to start python process.
*
- * @param pythonDriverOptions The Python driver options.
+ * @param config The configuration of python client dependencies.
* @param tmpDir The temporary directory which files will be copied to.
* @return PythonEnvironment the Python environment which will be
executed in Python process.
*/
public static PythonEnvironment preparePythonEnvironment(
- PythonDriverOptions pythonDriverOptions,
- String tmpDir) throws IOException, InterruptedException
{
+ ReadableConfig config,
+ String tmpDir) throws IOException {
+ Configuration contextConfig =
ExecutionEnvironment.getExecutionEnvironment().getConfiguration();
+
PythonEnvironment env = new PythonEnvironment();
+ // 1. setup the path of python interpreter.
+ if (config.getOptional(PYTHON_CLIENT_EXECUTABLE).isPresent()) {
Review comment:
Revert this change as it's out of the scope of this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
