GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/1464
[FLINK-3166] [runtime] The first program in ObjectReuseITCase has the wrong
expected result, and it succeeds
- TestEnvironment now honors configuration of object reuse
- Fixed reduce transformations to allow the user to modify and return
either input
This is neither clean nor complete but I wanted to get some feedback before
continuing.
ObjectReuseITCase was forcing object reuse, this was fixed by updating
TestEnvironment.
ReduceCombineDriver and ReduceDriver both requests the next record and call
the user's reduce() and so can handle whichever of the two inputs objects the
user might write to.
In the second test case DataSourceTask (which requests the next record)
calls ChainedAllReduceDriver.collect (which calls the user's reduce()). There
is no feedback so DataSourceTask must cycle through `n`+1 reusable objects for
unknown `n`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 3166_fix_objectreuseitcase
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1464.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1464
----
commit 78dc073440ed8ecfec51fbe33ce665562786bf20
Author: Greg Hogan <[email protected]>
Date: 2015-12-16T19:42:06Z
[FLINK-3166] [runtime] The first program in ObjectReuseITCase has the wrong
expected result, and it succeeds
- TestEnvironment now honors configuration of object reuse
- Fixed reduce transformations to allow the user to modify and return
either input
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
