Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1464#issuecomment-165406987
A few comments:
* the change to the TestEnvironment is unnecessary; ObjectReuse is
enabled/disabled in the JavaProgramTestBase. it doesn't fix anything, removing
the call to enabledObjectReuse in the test already did the trick.
* The ObjectReuseITCase is supposed to verify that objects are reused. Now,
the results are the same regardless of whether they are reused (except in case
3), making it little more then a reduce test. (There is also little point of
running this test with ObjectReuse disabled, which is why it forced it)
* A little bit above your changes in Reduce(Combine)Driver is a comment as
to why we only need 2 objects when reusing objects, this will need to be
adjusted.
* I like the changes in DataSourceTask/Reduce(Combine)Driver. They are a
seemingly simple solution for a common problem. In fact, But i am a bit
apprehensive about them, because i have a hard time imagining that no one else
could think of them; there might be a bigger issue with changes that i can't
see at the moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
