zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Avoid caching buffers for blocked input channels before barrier alignment
URL: https://github.com/apache/flink/pull/11351#discussion_r408976743
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
##########
@@ -89,7 +89,8 @@ public void triggerCheckpoint(long checkpointId) throws
FlinkException {
// TODO - we need to see how to derive
those. We should probably not encode this in the
// TODO - source's trigger message,
but do a handshake in this task between the trigger
// TODO - message from the master,
and the source's trigger notification
- final CheckpointOptions
checkpointOptions = CheckpointOptions.forCheckpointWithDefaultLocation();
+ final CheckpointOptions
checkpointOptions = CheckpointOptions.
Review comment:
nit: formatting only make the argument
`getConfiguration().isExactlyOnceCheckpointMode()` as as separate line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
