zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Avoid caching buffers for blocked input channels before barrier alignment
URL: https://github.com/apache/flink/pull/11351#discussion_r408908975
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/MultipleInputStreamTaskTest.java
##########
@@ -191,18 +183,15 @@ public void testOvertakingCheckpointBarriers() throws
Exception {
assertThat(testHarness.getOutput(),
contains(expectedOutput.toArray()));
- // Now give a later barrier to all inputs, this should
unblock the first channel,
- // thereby allowing the two blocked elements through
- testHarness.processEvent(new CheckpointBarrier(1, 1,
CheckpointOptions.forCheckpointWithDefaultLocation()), 0, 0);
+ // Now give a later barrier to all inputs, this should
unblock the first channel
testHarness.processEvent(new CheckpointBarrier(1, 1,
CheckpointOptions.forCheckpointWithDefaultLocation()), 0, 1);
testHarness.processEvent(new CheckpointBarrier(1, 1,
CheckpointOptions.forCheckpointWithDefaultLocation()), 1, 0);
testHarness.processEvent(new CheckpointBarrier(1, 1,
CheckpointOptions.forCheckpointWithDefaultLocation()), 1, 1);
testHarness.processEvent(new CheckpointBarrier(1, 1,
CheckpointOptions.forCheckpointWithDefaultLocation()), 2, 0);
testHarness.processEvent(new CheckpointBarrier(1, 1,
CheckpointOptions.forCheckpointWithDefaultLocation()), 2, 1);
+ testHarness.processEvent(new CheckpointBarrier(1, 1,
CheckpointOptions.forCheckpointWithDefaultLocation()), 0, 0);
Review comment:
we should not change the position of this operation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
