tillrohrmann commented on a change in pull request #11109:
[FLINK-15758][MemManager] Release segment and its unsafe memory in GC Cleaner
URL: https://github.com/apache/flink/pull/11109#discussion_r410262958
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/memory/MemoryManager.java
##########
@@ -387,12 +377,7 @@ public void releaseAll(Object owner) {
}
// free each segment
- long releasedMemory = 0L;
- for (MemorySegment segment : segments) {
- segment.free();
- releasedMemory += getPageSize();
- }
- releaseMemory(releasedMemory);
+ segments.forEach(MemorySegment::free);
Review comment:
I would suggest to follow the KISS principle: Keep it simple, stupid:
```suggestion
for (MemorySegment segment: segments) {
segment.free();
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
