tillrohrmann commented on a change in pull request #11109:
[FLINK-15758][MemManager] Release segment and its unsafe memory in GC Cleaner
URL: https://github.com/apache/flink/pull/11109#discussion_r410244991
##########
File path:
flink-core/src/main/java/org/apache/flink/core/memory/MemorySegmentFactory.java
##########
@@ -107,12 +113,14 @@ public static MemorySegment
allocateUnpooledOffHeapMemory(int size, Object owner
*
* @param size The size of the off-heap unsafe memory segment to
allocate.
* @param owner The owner to associate with the off-heap unsafe memory
segment.
+ * @param customGcCleaner A custom action to run upon calling GC
cleaner.
* @return A new memory segment, backed by off-heap unsafe memory.
*/
- public static MemorySegment allocateOffHeapUnsafeMemory(int size,
Object owner) {
+ public static MemorySegment allocateOffHeapUnsafeMemory(int size,
Object owner, Runnable customGcCleaner) {
Review comment:
```suggestion
public static MemorySegment allocateOffHeapUnsafeMemory(int size,
Object owner, Runnable customCleanupAction) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
