tillrohrmann commented on a change in pull request #11109:
[FLINK-15758][MemManager] Release segment and its unsafe memory in GC Cleaner
URL: https://github.com/apache/flink/pull/11109#discussion_r410264001
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/memory/MemoryManager.java
##########
@@ -637,44 +622,7 @@ public long computeMemorySize(double fraction) {
"The fraction of memory to allocate must within (0, 1],
was: %s", fraction);
//noinspection NumericCastThatLosesPrecision
Review comment:
Please don't add suppressions for IntelliJ's inspections. I think here we
are mixing dev specific tooling with Flink code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services