pnowojski commented on a change in pull request #11899:
URL: https://github.com/apache/flink/pull/11899#discussion_r417211460
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -144,16 +148,15 @@
* enforce minimum processing time between checkpoint attempts */
private final long minPauseBetweenCheckpoints;
- /** The maximum number of checkpoints that may be in progress at the
same time. */
- private final int maxConcurrentCheckpointAttempts;
-
/** The timer that handles the checkpoint timeouts and triggers
periodic checkpoints.
* It must be single-threaded. Eventually it will be replaced by main
thread executor. */
private final ScheduledExecutor timer;
/** The master checkpoint hooks executed by this checkpoint
coordinator. */
private final HashMap<String, MasterTriggerRestoreHook<?>> masterHooks;
+ private final boolean isUnalignedCheckpointsEnabled;
Review comment:
`areUnalignedCheckpointsEnabled`
nit: and the rename from `isUnalignedCheckpoint` should have been a separate
commit :)
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -144,16 +148,15 @@
* enforce minimum processing time between checkpoint attempts */
private final long minPauseBetweenCheckpoints;
- /** The maximum number of checkpoints that may be in progress at the
same time. */
- private final int maxConcurrentCheckpointAttempts;
-
/** The timer that handles the checkpoint timeouts and triggers
periodic checkpoints.
* It must be single-threaded. Eventually it will be replaced by main
thread executor. */
private final ScheduledExecutor timer;
/** The master checkpoint hooks executed by this checkpoint
coordinator. */
private final HashMap<String, MasterTriggerRestoreHook<?>> masterHooks;
+ private final boolean isUnalignedCheckpointsEnabled;
Review comment:
`areUnalignedCheckpointsEnabled`
nit: and the rename from `isUnalignedCheckpoint` should/could have been a
separate commit :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
