pnowojski commented on a change in pull request #11899:
URL: https://github.com/apache/flink/pull/11899#discussion_r417214265
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorRestoringTest.java
##########
@@ -813,13 +809,11 @@ public void
testStateRecoveryWithTopologyChange(TestScaleType scaleType) throws
CheckpointProperties.forCheckpoint(CheckpointRetentionPolicy.NEVER_RETAIN_AFTER_TERMINATION),
new TestCompletedCheckpointStorageLocation());
-
when(standaloneCompletedCheckpointStore.getLatestCheckpoint(false)).thenReturn(completedCheckpoint);
-
// set up the coordinator and validate the initial state
CheckpointCoordinator coord =
new CheckpointCoordinatorBuilder()
.setTasks(newJobVertex1.getTaskVertices())
-
.setCompletedCheckpointStore(standaloneCompletedCheckpointStore)
+
.setCompletedCheckpointStore(CompletedCheckpointStore.storeFor(completedCheckpoint))
Review comment:
nit: this is a small change, but I also tend to "demockitofy" tests in a
separate commit (when I'm finding a test failing because of mockito, I
rebase/stash all of my changes, fix the test and re-apply my changes).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
