pnowojski commented on a change in pull request #11899:
URL: https://github.com/apache/flink/pull/11899#discussion_r417274966
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -43,7 +43,6 @@
import org.apache.flink.runtime.state.StateBackend;
Review comment:
Generally speaking I'm not a big fan of this last commit, as it will
make our lives more difficult to re-apply reverted refactoring commits. So I
would actually prefer to drop/suspend it for now.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -535,20 +540,16 @@ private void
startTriggeringCheckpoint(CheckpointTriggerRequest request) {
request.getOnCompletionFuture()),
timer);
- final CompletableFuture<?> masterStatesComplete =
pendingCheckpointCompletableFuture
- .thenCompose(this::snapshotMasterState);
+ final CompletableFuture<?> masterStatesComplete =
pendingCheckpointCompletableFuture.thenCompose(this::snapshotMasterState);
- final CompletableFuture<?>
coordinatorCheckpointsComplete = pendingCheckpointCompletableFuture
- .thenComposeAsync((pendingCheckpoint) ->
-
OperatorCoordinatorCheckpoints.triggerAndAcknowledgeAllCoordinatorCheckpointsWithCompletion(
-
coordinatorsToCheckpoint, pendingCheckpoint, timer),
- timer);
+ final CompletableFuture<?>
coordinatorCheckpointsComplete =
pendingCheckpointCompletableFuture.thenComposeAsync(
+ pendingCheckpoint ->
triggerAndAcknowledgeAllCoordinatorCheckpointsWithCompletion(coordinatorsToCheckpoint,
pendingCheckpoint, timer),
+ timer);
Review comment:
Those lines should be wrapped somehow, also in other places after your
changes lines are too long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
