[
https://issues.apache.org/jira/browse/FLINK-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098128#comment-15098128
]
ASF GitHub Bot commented on FLINK-2871:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49728408
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/util/HashVsSortMiniBenchmark.java
---
@@ -130,11 +130,11 @@ public void testSortBothMerge() {
final UnilateralSortMerger<Tuple2<Integer, String>>
sorter1 = new UnilateralSortMerger<>(
this.memoryManager, this.ioManager,
input1, this.parentTask, this.serializer1,
- this.comparator1.duplicate(),
MEMORY_FOR_SORTER, 128, 0.8f, true);
+ this.comparator1.duplicate(),
(double)MEMORY_FOR_SORTER/MEMORY_SIZE, 128, 0.8f, true);
--- End diff --
Why did you change this line?
> Add OuterJoin strategy with HashTable on outer side
> ---------------------------------------------------
>
> Key: FLINK-2871
> URL: https://issues.apache.org/jira/browse/FLINK-2871
> Project: Flink
> Issue Type: New Feature
> Components: Local Runtime, Optimizer
> Affects Versions: 0.10.0
> Reporter: Fabian Hueske
> Assignee: Chengxiang Li
> Priority: Minor
>
> Outer joins are currently supported with two local execution strategies:
> - sort-merge join
> - hash join where the hash table is built on the inner side. Hence, this
> strategy is only supported for left and right outer joins.
> In order to support hash-tables on the outer side, we need a special hash
> table implementation that gives access to all records which have not been
> accessed during the probe phase.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)