[ 
https://issues.apache.org/jira/browse/FLINK-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098133#comment-15098133
 ] 

ASF GitHub Bot commented on FLINK-2871:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1469#issuecomment-171652959
  
    The tests look mostly good. 
    I would change the `HashTableITCase.testHashWithBuildSideOuterJoin2()` to 
process outer join tuples.
    Can you explain the rational for the changes in `HashVsSortMiniBenchmark`?
    
    Thanks, Fabian


> Add OuterJoin strategy with HashTable on outer side
> ---------------------------------------------------
>
>                 Key: FLINK-2871
>                 URL: https://issues.apache.org/jira/browse/FLINK-2871
>             Project: Flink
>          Issue Type: New Feature
>          Components: Local Runtime, Optimizer
>    Affects Versions: 0.10.0
>            Reporter: Fabian Hueske
>            Assignee: Chengxiang Li
>            Priority: Minor
>
> Outer joins are currently supported with two local execution strategies:
> - sort-merge join
> - hash join where the hash table is built on the inner side. Hence, this 
> strategy is only supported for left and right outer joins.
> In order to support hash-tables on the outer side, we need a special hash 
> table implementation that gives access to all records which have not been 
> accessed during the probe phase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to