JingsongLi commented on a change in pull request #12053:
URL: https://github.com/apache/flink/pull/12053#discussion_r422473420



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -401,6 +402,7 @@ public T withOutputFileConfig(final OutputFileConfig 
outputFileConfig) {
                                        bucketFactory,
                                        new 
BulkPartWriter.Factory<>(writerFactory),
                                        rollingPolicy,
+                                       null,

Review comment:
       Add litener setter to this bulk part writer builder?

##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -401,6 +402,7 @@ public T withOutputFileConfig(final OutputFileConfig 
outputFileConfig) {
                                        bucketFactory,
                                        new 
BulkPartWriter.Factory<>(writerFactory),
                                        rollingPolicy,
+                                       null,

Review comment:
       Add litsener setter to this bulk part writer builder?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to