JingsongLi commented on a change in pull request #12053:
URL: https://github.com/apache/flink/pull/12053#discussion_r422473459
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -291,6 +291,7 @@ T withBucketFactory(final BucketFactory<IN, BucketID>
factory) {
bucketFactory,
new
RowWisePartWriter.Factory<>(encoder),
rollingPolicy,
+ null,
Review comment:
Add listener setter to this row wise part writer builder?
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Buckets.java
##########
@@ -65,6 +65,9 @@
private final RollingPolicy<IN, BucketID> rollingPolicy;
+ @Nullable
+ private final BucketLifeCycleListener<IN, BucketID>
bucketLifeCycleListener;
Review comment:
Should this be a `List<Listener>`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
