Draczech commented on a change in pull request #12560:
URL: https://github.com/apache/flink/pull/12560#discussion_r437921709
##########
File path:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/history/HistoryServerTest.java
##########
@@ -78,6 +78,7 @@
.disable(JsonGenerator.Feature.AUTO_CLOSE_JSON_CONTENT);
private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper()
.enable(DeserializationFeature.FAIL_ON_MISSING_CREATOR_PROPERTIES);
+ private static final String JSON_FILE_ENDING = ".json";
Review comment:
I guess that wouldn't be problem. There could be even more constants
shared between `HistoryServerArchiveFetcher` and `HistoryServerTest` to make
the code a bit cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
